[PATCH 1/1] drm/amdgpu: Use device wedged event

[Sharma, Shashank]

[AMD Official Use Only - AMD Internal Distribution Only]

Looks good to me as well, With Christian's comment accommodated:
Acked-by: Shashank Sharma <shashank.sharma at amd.com>

Regards
Shashank
________________________________
From: Koenig, Christian <Christian.Koenig at amd.com>
Sent: Friday, December 13, 2024 8:34 AM
To: André Almeida <andrealmeid at igalia.com>; Raag Jadav <raag.jadav at intel.com>; airlied at gmail.com <airlied at gmail.com>; simona at ffwll.ch <simona at ffwll.ch>; lucas.demarchi at intel.com <lucas.demarchi at intel.com>; rodrigo.vivi at intel.com <rodrigo.vivi at intel.com>; jani.nikula at linux.intel.com <jani.nikula at linux.intel.com>; andriy.shevchenko at linux.intel.com <andriy.shevchenko at linux.intel.com>; lina at asahilina.net <lina at asahilina.net>; michal.wajdeczko at intel.com <michal.wajdeczko at intel.com>; Sharma, Shashank <Shashank.Sharma at amd.com>
Cc: intel-gfx at lists.freedesktop.org <intel-gfx at lists.freedesktop.org>; dri-devel at lists.freedesktop.org <dri-devel at lists.freedesktop.org>; himal.prasad.ghimiray at intel.com <himal.prasad.ghimiray at intel.com>; aravind.iddamsetty at linux.intel.com <aravind.iddamsetty at linux.intel.com>; anshuman.gupta at intel.com <anshuman.gupta at intel.com>; Deucher, Alexander <Alexander.Deucher at amd.com>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>; kernel-dev at igalia.com <kernel-dev at igalia.com>
Subject: Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

Am 12.12.24 um 20:09 schrieb André Almeida:
> Use DRM's device wedged event to notify userspace that a reset had
> happened. For now, only use `none` method meant for telemetry
> capture.
>
> Signed-off-by: André Almeida <andrealmeid at igalia.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 96316111300a..19e1a5493778 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -6057,6 +6057,9 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
>                dev_info(adev->dev, "GPU reset end with ret = %d\n", r);
>
>        atomic_set(&adev->reset_domain->reset_res, r);
> +
> +     drm_dev_wedged_event(adev_to_drm(adev), DRM_WEDGE_RECOVERY_NONE);

That looks really good in general. I would just make the
DRM_WEDGE_RECOVERY_NONE depend on the value of "r".

@Shashank any objections? IIRC you have worked on the AMD specific event
we never upstreamed.

Regards,
Christian.

> +
>        return r;
>   }
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20241213/1fc404f4/attachment-0001.htm>