[PATCH v2 7/7] drm/amdgpu: Apply sign extension to seq64

Christian König christian.koenig at amd.com
Fri Dec 13 10:55:14 UTC 2024


Am 12.12.24 um 15:25 schrieb Arunpravin Paneer Selvam:
> Apply sign extension to seq64 va address.
>
> Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> index 898d215a8d99..2de1a844282e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> @@ -45,7 +45,11 @@
>    */
>   static inline u64 amdgpu_seq64_get_va_base(struct amdgpu_device *adev)
>   {
> -	return AMDGPU_VA_RESERVED_SEQ64_START(adev);
> +	u64 addr = AMDGPU_VA_RESERVED_SEQ64_START(adev);
> +
> +	addr = amdgpu_gmc_sign_extend(addr);
> +
> +	return addr;
>   }
>   
>   /**
> @@ -88,7 +92,7 @@ int amdgpu_seq64_map(struct amdgpu_device *adev, struct amdgpu_vm *vm,
>   		goto error;
>   	}
>   
> -	seq64_addr = amdgpu_seq64_get_va_base(adev);
> +	seq64_addr = amdgpu_seq64_get_va_base(adev) & AMDGPU_GMC_HOLE_MASK;
>   	r = amdgpu_vm_bo_map(adev, *bo_va, seq64_addr, 0, AMDGPU_VA_RESERVED_SEQ64_SIZE,
>   			     AMDGPU_PTE_READABLE);
>   	if (r) {



More information about the amd-gfx mailing list