[PATCH] drm/amdkfd: Fix L2 cache size reporting in GFX9.4.3

[Errabolu, Ramesh]

[AMD Official Use Only - General]

Comments inline.

Regards,
Ramesh

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Joshi, Mukul
Sent: Wednesday, February 7, 2024 1:36 AM
To: Russell, Kent <Kent.Russell at amd.com>; amd-gfx at lists.freedesktop.org
Subject: RE: [PATCH] drm/amdkfd: Fix L2 cache size reporting in GFX9.4.3

[AMD Official Use Only - General]

[AMD Official Use Only - General]

The commit description needs a Fixes tag of the offending commit.
With that fixed, this patch is:

Reviewed-by: Mukul Joshi <mukul.joshi at amd.com>

> -----Original Message-----
> From: Russell, Kent <Kent.Russell at amd.com>
> Sent: Tuesday, February 6, 2024 1:06 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Joshi, Mukul <Mukul.Joshi at amd.com>; Russell, Kent
> <Kent.Russell at amd.com>
> Subject: [PATCH] drm/amdkfd: Fix L2 cache size reporting in GFX9.4.3
>
> Its currently incorrectly multiplied by number of XCCs in the
> partition
>
> Signed-off-by: Kent Russell <kent.russell at amd.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index 3df2a8ad86fb..64bf2a56f010 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -1640,9 +1640,7 @@ static int fill_in_l2_l3_pcache(struct
> kfd_cache_properties **props_ext,
>               else
>                       mode = UNKNOWN_MEMORY_PARTITION_MODE;
>
> -             if (pcache->cache_level == 2)
> -                     pcache->cache_size =
> pcache_info[cache_type].cache_size * num_xcc;
> -             else if (mode)
> +             if (mode)
>                       pcache->cache_size =
> pcache_info[cache_type].cache_size / mode;
>               else
>                       pcache->cache_size =
> pcache_info[cache_type].cache_size;
Ramesh: Per my reading a cache_size is correct and should be around 4 MiB. Per my thinking "mode" does not come into play?
> --
> 2.34.1