[PATCH v2] drm/amdkfd: Initialize kfd_gpu_cache_info for KFD topology

Felix Kuehling felix.kuehling at amd.com
Wed Feb 7 05:38:23 UTC 2024


On 2024-02-07 0:32, Joseph Greathouse wrote:
> The current kfd_gpu_cache_info structure is only partially
> filled in for some architectures. This means that for devices
> where we do not fill in some fields, we can returned
> uninitialized values through  the KFD topology.
> Zero out the kfd_gpu_cache_info before asking the remaining
> fields to be filled in by lower-level functions.
>
> Fixes: 04756ac9a24c ("drm/amdkfd: Add cache line sizes to KFD topology")
> Signed-off-by: Joseph Greathouse <Joseph.Greathouse at amd.com>

Reviewed-by: Felix Kuehling <felix.kuehling at amd.com>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index 3df2a8ad86fb..5cb0465493b8 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -1707,6 +1707,7 @@ static void kfd_fill_cache_non_crat_info(struct kfd_topology_device *dev, struct
>   
>   	gpu_processor_id = dev->node_props.simd_id_base;
>   
> +	memset(cache_info, 0, sizeof(cache_info));
>   	pcache_info = cache_info;
>   	num_of_cache_types = kfd_get_gpu_cache_info(kdev, &pcache_info);
>   	if (!num_of_cache_types) {


More information about the amd-gfx mailing list