[PATCH] drm/amdgpu: Fix missing parameter descriptions in ih_v7_0.c

[Christian König]

Am 15.02.24 um 13:38 schrieb Srinivasan Shanmugam:
> Rectifies kdoc warnings related to the 'ih' parameter in the
> 'ih_v7_0_get_wptr', 'ih_v7_0_irq_rearm', and 'ih_v7_0_set_rptr'
> functions within the 'ih_v7_0.c' file.
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/ih_v7_0.c:392: warning: Function parameter or member 'ih' not described in 'ih_v7_0_get_wptr'
> drivers/gpu/drm/amd/amdgpu/ih_v7_0.c:432: warning: Function parameter or member 'ih' not described in 'ih_v7_0_irq_rearm'
> drivers/gpu/drm/amd/amdgpu/ih_v7_0.c:458: warning: Function parameter or member 'ih' not described in 'ih_v7_0_set_rptr'
>
> Fixes: b6ba7a165b13 ("drm/amdgpu: Add ih v7_0 ip block support")
> Cc: Likun Gao <Likun.Gao at amd.com>
> Cc: Hawking Zhang <Hawking.Zhang at amd.com>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/ih_v7_0.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/ih_v7_0.c b/drivers/gpu/drm/amd/amdgpu/ih_v7_0.c
> index 236806797b23..16fe428c0722 100644
> --- a/drivers/gpu/drm/amd/amdgpu/ih_v7_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/ih_v7_0.c
> @@ -378,9 +378,10 @@ static void ih_v7_0_irq_disable(struct amdgpu_device *adev)
>   }
>   
>   /**
> - * ih_v7_0_get_wptr - get the IH ring buffer wptr
> + * ih_v7_0_get_wptr() - get the IH ring buffer wptr
>    *
>    * @adev: amdgpu_device pointer
> + * @ih: IH ring buffer to fetch wptr
>    *
>    * Get the IH ring buffer wptr from either the register
>    * or the writeback memory buffer.  Also check for
> @@ -425,6 +426,7 @@ static u32 ih_v7_0_get_wptr(struct amdgpu_device *adev,
>    * ih_v7_0_irq_rearm - rearm IRQ if lost
>    *
>    * @adev: amdgpu_device pointer
> + * @ih: IH ring to match
>    *
>    */
>   static void ih_v7_0_irq_rearm(struct amdgpu_device *adev,
> @@ -450,8 +452,7 @@ static void ih_v7_0_irq_rearm(struct amdgpu_device *adev,
>    * ih_v7_0_set_rptr - set the IH ring buffer rptr
>    *
>    * @adev: amdgpu_device pointer
> - *
> - * Set the IH ring buffer rptr.
> + * @ih: IH ring buffer to set rptr
>    */
>   static void ih_v7_0_set_rptr(struct amdgpu_device *adev,
>   			       struct amdgpu_ih_ring *ih)