[PATCH libdrm 1/2] amdgpu: fix parameter of amdgpu_cs_ctx_create2

Christian König christian.koenig at amd.com
Mon Jan 8 16:28:30 UTC 2024


Am 08.01.24 um 10:40 schrieb Zhenneng Li:
> In order to pass the correct priority parameter to the kernel,
> we must change priority type from uint32_t to int32_t.

Hui what? Why should it matter if the parameter is signed or not?

That doesn't seem to make sense.

Regards,
Christian.

>
> Signed-off-by: Zhenneng Li <lizhenneng at kylinos.cn>
> ---
>   amdgpu/amdgpu.h    | 2 +-
>   amdgpu/amdgpu_cs.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h
> index 9bdbf366..f46753f3 100644
> --- a/amdgpu/amdgpu.h
> +++ b/amdgpu/amdgpu.h
> @@ -896,7 +896,7 @@ int amdgpu_bo_list_update(amdgpu_bo_list_handle handle,
>    *
>   */
>   int amdgpu_cs_ctx_create2(amdgpu_device_handle dev,
> -			 uint32_t priority,
> +			 int32_t priority,
>   			 amdgpu_context_handle *context);
>   /**
>    * Create GPU execution Context
> diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c
> index 49fc16c3..eb72c638 100644
> --- a/amdgpu/amdgpu_cs.c
> +++ b/amdgpu/amdgpu_cs.c
> @@ -49,7 +49,7 @@ static int amdgpu_cs_reset_sem(amdgpu_semaphore_handle sem);
>    * \return  0 on success otherwise POSIX Error code
>   */
>   drm_public int amdgpu_cs_ctx_create2(amdgpu_device_handle dev,
> -				     uint32_t priority,
> +				     int32_t priority,
>   				     amdgpu_context_handle *context)
>   {
>   	struct amdgpu_context *gpu_context;



More information about the amd-gfx mailing list