[PATCH] drm/amdgpu: make a correction on comment

James Zhu jamesz at amd.com
Mon Jan 8 17:17:02 UTC 2024


On 2024-01-08 03:12, Christian König wrote:
> Am 02.01.24 um 21:56 schrieb James Zhu:
>> Current AMDGPU_VM_RESERVED_VRAM is updated to 8M.
>>
>> Signed-off-by: James Zhu <James.Zhu at amd.com>
>
> Maybe remove the value completely from the comment, just something 
> like "How much memory be reserved for page tables".
[JZ] This will work better. Thanks!
>
> Either way Reviewed-by: Christian König <christian.koenig at amd.com>
>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
>> index b6cd565562ad..b788067b9158 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
>> @@ -116,7 +116,7 @@ struct amdgpu_mem_stats;
>>   #define AMDGPU_VM_FAULT_STOP_FIRST    1
>>   #define AMDGPU_VM_FAULT_STOP_ALWAYS    2
>>   -/* Reserve 4MB VRAM for page tables */
>> +/* Reserve 8MB VRAM for page tables */
>>   #define AMDGPU_VM_RESERVED_VRAM        (8ULL << 20)
>>     /*
>


More information about the amd-gfx mailing list