[PATCH] drm/amdgpu: Remove unnecessary NULL check

Christian König ckoenig.leichtzumerken at gmail.com
Tue Jan 16 20:00:23 UTC 2024


Am 15.01.24 um 23:57 schrieb Felix Kuehling:
> A static checker pointed out, that bo_va->base.bo was already derefenced
> earlier in the same scope. Therefore this check is unnecessary here.
>
> Reported-by: Dan Carpenter <dan.carpenter at linaro.org>
> Fixes: 79e7fdec71f2 ("drm/amdgpu: Auto-validate DMABuf imports in compute VMs")
> Signed-off-by: Felix Kuehling <felix.kuehling at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 77d015ebb201..b7f07cc52b1b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1477,7 +1477,7 @@ int amdgpu_vm_handle_moved(struct amdgpu_device *adev,
>   		/* Remember evicted DMABuf imports in compute VMs for later
>   		 * validation
>   		 */
> -		if (vm->is_compute_context && bo_va->base.bo &&
> +		if (vm->is_compute_context &&
>   		    bo_va->base.bo->tbo.base.import_attach &&
>   		    (!bo_va->base.bo->tbo.resource ||
>   		     bo_va->base.bo->tbo.resource->mem_type == TTM_PL_SYSTEM))



More information about the amd-gfx mailing list