[PATCH] drm/amd/pm: enable amdgpu smu send message log

Lazar, Lijo lijo.lazar at amd.com
Thu Jan 18 05:13:16 UTC 2024


On 1/18/2024 8:56 AM, Yang Wang wrote:
> From: Yang Wang <KevinYang.Wang at amd.com>
> 
> enable amdgpu smu driver message log.
> 
> Signed-off-by: Yang Wang <KevinYang.Wang at amd.com>
> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> index 00cd615bbcdc..b9a24ff02a12 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> @@ -378,8 +378,14 @@ int smu_cmn_send_smc_msg_with_param(struct smu_context *smu,
>   	res = __smu_cmn_reg2errno(smu, reg);
>   	if (res != 0)
>   		__smu_cmn_reg_print_error(smu, reg, index, param, msg);
> -	if (read_arg)
> +	if (read_arg) {
>   		smu_cmn_read_arg(smu, read_arg);
> +		dev_dbg(adev->dev, "smu send message: %s(%d) param: 0x%08x, readval: 0x%08x\n",
> +			smu_get_message_name(smu, msg), index, param, *read_arg);
> +	} else {
> +		dev_dbg(adev->dev, "smu send message: %s(%d) param: 0x%08x\n",
> +			smu_get_message_name(smu, msg), index, param);
> +	}

Better to add the exact response reg value (reg = 
__smu_cmn_poll_stat(smu)) also to this.

Thanks,
Lijo

>   Out:
>   	if (unlikely(adev->pm.smu_debug_mask & SMU_DEBUG_HALT_ON_ERROR) && res) {
>   		amdgpu_device_halt(adev);



More information about the amd-gfx mailing list