[PATCH] drm/amd/display: Drop kdoc markers for some Panel Replay functions

Alex Deucher alexdeucher at gmail.com
Thu Jan 18 14:23:33 UTC 2024


On Thu, Jan 18, 2024 at 9:22 AM Srinivasan Shanmugam
<srinivasan.shanmugam at amd.com> wrote:
>
> Fixes the below gcc with W=1:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c:262: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>  * Set REPLAY power optimization flags and coasting vtotal.
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c:284: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>  * send Replay general cmd to DMUB.
>
> Fixes: 340b072e38d3 ("drm/amd/display: Add some functions for Panel Replay")
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Cc: Rodrigo Siqueira <rodrigo.siqueira at amd.com>
> Cc: Leo Li <sunpeng.li at amd.com>
> Cc: Tom Chung <chiahsuan.chung at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c
> index 38e4797e9476..b010814706fe 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c
> @@ -258,7 +258,7 @@ static void dmub_replay_residency(struct dmub_replay *dmub, uint8_t panel_inst,
>                 *residency = 0;
>  }
>
> -/**
> +/*
>   * Set REPLAY power optimization flags and coasting vtotal.
>   */
>  static void dmub_replay_set_power_opt_and_coasting_vtotal(struct dmub_replay *dmub,
> @@ -280,7 +280,7 @@ static void dmub_replay_set_power_opt_and_coasting_vtotal(struct dmub_replay *dm
>         dc_wake_and_execute_dmub_cmd(dc, &cmd, DM_DMUB_WAIT_TYPE_WAIT);
>  }
>
> -/**
> +/*
>   * send Replay general cmd to DMUB.
>   */
>  static void dmub_replay_send_cmd(struct dmub_replay *dmub,
> --
> 2.34.1
>


More information about the amd-gfx mailing list