[PATCH 3/3] drm/amd/display: "Enable IPS by default"

[Mario Limonciello]

On 1/24/2024 11:09, Roman.Li at amd.com wrote:
> From: Roman Li <Roman.Li at amd.com>
> 
> [Why]
> IPS was temporary disabled due to instability.
> It was fixed in dmub firmware and with:
> - "drm/amd/display: Add IPS checks before dcn register access"
> - "drm/amd/display: Disable ips before dc interrupt setting"
> 
> [How]
> Enable IPS by default.
> Disable IPS if 0x800 bit set in amdgpu.dcdebugmask module params
> 
> Signed-off-by: Roman Li <Roman.Li at amd.com>
> Tested-by: Mark Broadworth <mark.broadworth at amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello at amd.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 41994a60e2cd..9d909c09a14f 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1719,7 +1719,8 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
>   	init_data.nbio_reg_offsets = adev->reg_offset[NBIO_HWIP][0];
>   	init_data.clk_reg_offsets = adev->reg_offset[CLK_HWIP][0];
>   
> -	init_data.flags.disable_ips = DMUB_IPS_DISABLE_ALL;
> +        if (amdgpu_dc_debug_mask & DC_DISABLE_IPS)
> +		init_data.flags.disable_ips = DMUB_IPS_DISABLE_ALL;
>   
>   	init_data.flags.disable_ips_in_vpb = 1;
>