[PATCH v1 3/3] drm/amdgpu: select compute ME engines dynamically

[Khatri, Sunil]

[AMD Official Use Only - AMD Internal Distribution Only]

Thanks Alex

-----Original Message-----
From: Alex Deucher <alexdeucher at gmail.com>
Sent: Tuesday, July 9, 2024 7:27 PM
To: Khatri, Sunil <Sunil.Khatri at amd.com>
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH v1 3/3] drm/amdgpu: select compute ME engines dynamically

Makes sense, although the pattern elsewhere is to just start at 1 for mec.  Not sure if it's worth the effort to fix all of those cases up too.
True, but will keep a check on gfx13 and onwards and may be we would have a more than one ME for gfx in some chip and then we have to take care of it explicitly.

Series is:
Acked-by: Alex Deucher <alexander.deucher at amd.com>

On Tue, Jul 9, 2024 at 2:07 AM Sunil Khatri <sunil.khatri at amd.com> wrote:
>
> GFX ME right now is one but this could change in future SOC's. Use no
> of ME for GFX as start point for ME for compute for GFX12.
>
> Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
> index 084b039eb765..f384be0d1800 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
> @@ -4946,7 +4946,7 @@ static void gfx_v12_ip_dump(void *handle)
>                 for (j = 0; j < adev->gfx.mec.num_pipe_per_mec; j++) {
>                         for (k = 0; k < adev->gfx.mec.num_queue_per_pipe; k++) {
>                                 /* ME0 is for GFX so start from 1 for CP */
> -                               soc24_grbm_select(adev, 1+i, j, k, 0);
> +                               soc24_grbm_select(adev,
> + adev->gfx.me.num_me + i, j, k, 0);
>                                 for (reg = 0; reg < reg_count; reg++) {
>                                         adev->gfx.ip_dump_compute_queues[index + reg] =
>
> RREG32(SOC15_REG_ENTRY_OFFSET(
> --
> 2.34.1
>