[PATCH 09/22] drm/amd/display: Check if Mode is Supported Before Returning Result
Aurabindo Pillai
aurabindo.pillai at amd.com
Wed Jul 17 19:38:48 UTC 2024
From: Austin Zheng <austin.zheng at amd.com>
[Why]
Even if the mode is not supported dml2_check_mode_supported() would still return true.
This causes an unsupported mode to be programmed.
[How]
Check if the mode is supported or not and return the proper result.
Reviewed-by: Chaitanya Dhere <chaitanya.dhere at amd.com>
Signed-off-by: Aurabindo Pillai <aurabindo.pillai at amd.com>
Signed-off-by: Austin Zheng <austin.zheng at amd.com>
---
.../gpu/drm/amd/display/dc/dml2/dml21/src/dml2_top/dml_top.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_top/dml_top.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_top/dml_top.c
index 30d07cd1065f..e9b40a45ffdd 100644
--- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_top/dml_top.c
+++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_top/dml_top.c
@@ -138,8 +138,9 @@ bool dml2_check_mode_supported(struct dml2_check_mode_supported_in_out *in_out)
}
in_out->is_supported = mcache_success;
+ result = result && in_out->is_supported;
- return true;
+ return result;
}
bool dml2_build_mode_programming(struct dml2_build_mode_programming_in_out *in_out)
--
2.39.2
More information about the amd-gfx
mailing list