[PATCH 05/12] drm/amd/pm: remove dead code in navi10_emit_clk_levels and navi10_print_clk_levels

Huang, Tim Tim.Huang at amd.com
Wed Jun 5 07:48:19 UTC 2024


[Public]

This patch is,

Reviewed-by: Tim Huang <Tim.Huang at amd.com>



> -----Original Message-----
> From: Jesse Zhang <jesse.zhang at amd.com>
> Sent: Monday, June 3, 2024 4:48 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian
> <Christian.Koenig at amd.com>; Kuehling, Felix <Felix.Kuehling at amd.com>;
> Huang, Tim <Tim.Huang at amd.com>; Zhang, Jesse(Jie)
> <Jesse.Zhang at amd.com>; Zhang, Jesse(Jie) <Jesse.Zhang at amd.com>
> Subject: [PATCH 05/12] drm/amd/pm: remove dead code in
> navi10_emit_clk_levels and navi10_print_clk_levels
>
> Since the range of the varibable i is 0 - 3.
> So execution cannot reach this statement: default.
>
> Signed-off-by: Jesse Zhang <Jesse.Zhang at amd.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> index cf556f1b5ed1..076620fa3ef5 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> @@ -1389,8 +1389,6 @@ static int navi10_emit_clk_levels(struct
> smu_context *smu,
>                       case 2:
>                               curve_settings = &od_table->GfxclkFreq3;
>                               break;
> -                     default:
> -                             break;
>                       }
>                       *offset += sysfs_emit_at(buf, *offset,
> "%d: %uMHz %umV\n",
>                                                 i, curve_settings[0],
> @@ -1594,8 +1592,6 @@ static int navi10_print_clk_levels(struct
> smu_context *smu,
>                       case 2:
>                               curve_settings = &od_table->GfxclkFreq3;
>                               break;
> -                     default:
> -                             break;
>                       }
>                       size += sysfs_emit_at(buf, size,
> "%d: %uMHz %umV\n",
>                                             i, curve_settings[0],
> --
> 2.25.1



More information about the amd-gfx mailing list