[PATCH] drm/amdgpu: Fix hbm stack id in boot error report

Zhou1, Tao Tao.Zhou1 at amd.com
Fri Jun 28 09:22:16 UTC 2024


[AMD Official Use Only - AMD Internal Distribution Only]

How about:

hbm_id = AMDGPU_RAS_GPU_ERR_HBM_ID(boot_error) - 1;

Anyway, the patch is:

Reviewed-by: Tao Zhou <tao.zhou1 at amd.com>

> -----Original Message-----
> From: Hawking Zhang <Hawking.Zhang at amd.com>
> Sent: Friday, June 28, 2024 5:04 PM
> To: amd-gfx at lists.freedesktop.org; Zhou1, Tao <Tao.Zhou1 at amd.com>
> Cc: Zhang, Hawking <Hawking.Zhang at amd.com>
> Subject: [PATCH] drm/amdgpu: Fix hbm stack id in boot error report
>
> To align with firmware, hbm id field 0x1 refers to hbm stack 0, 0x2 refers to hbm
> statck 1.
>
> Signed-off-by: Hawking Zhang <Hawking.Zhang at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index 4edd8e333d36..6d1f974e2987 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -4565,7 +4565,7 @@ static void
> amdgpu_ras_boot_time_error_reporting(struct amdgpu_device *adev,
>
>       socket_id = AMDGPU_RAS_GPU_ERR_SOCKET_ID(boot_error);
>       aid_id = AMDGPU_RAS_GPU_ERR_AID_ID(boot_error);
> -     hbm_id = AMDGPU_RAS_GPU_ERR_HBM_ID(boot_error);
> +     hbm_id = ((1 == AMDGPU_RAS_GPU_ERR_HBM_ID(boot_error)) ? 0 : 1);
>
>       if (AMDGPU_RAS_GPU_ERR_MEM_TRAINING(boot_error))
>               dev_info(adev->dev,
> --
> 2.17.1



More information about the amd-gfx mailing list