[PATCH 03/43] drm/amd/display: Enable 2to1 ODM policy for DCN35

Christian König ckoenig.leichtzumerken at gmail.com
Tue Mar 12 10:20:37 UTC 2024


Just another general comment on how to upstream patches.

When publishing a large set of patches it is usually good convention to 
sort them:
1. Bug fixes which might even get backported
2. Comment and other non function cleanups
3. Functional cleanups
4. New features

One good reason for that is that it usually makes fixes much easier to 
port to older kernel versions, but it also makes things easier to review.

If you are in doubt if a patch set is still fully compiling after 
re-ordering things you can use the command

git rebase -x make base_branch

On your branch and git will run a make between after applying each 
patch. This way you can double check that everything still builds fine.

Working like that is not a must have, but really good practice.

Regards,
Christian.

Am 12.03.24 um 10:19 schrieb Wayne Lin:
> From: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
>
> [Why & How]
> Enable 2to1 ODM policy for DCN35
>
> Acked-by: Wayne Lin <wayne.lin at amd.com>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c
> index 5d52853cac96..a8f4023ff3b1 100644
> --- a/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c
> @@ -769,7 +769,7 @@ static const struct dc_debug_options debug_defaults_drv = {
>   	.support_eDP1_5 = true,
>   	.enable_hpo_pg_support = false,
>   	.enable_legacy_fast_update = true,
> -	.enable_single_display_2to1_odm_policy = false,
> +	.enable_single_display_2to1_odm_policy = true,
>   	.disable_idle_power_optimizations = false,
>   	.dmcub_emulation = false,
>   	.disable_boot_optimizations = false,



More information about the amd-gfx mailing list