[PATCH] drm/amd/display: Address kdoc for commit_minimal_transition_state_in_dc_update()

Rodrigo Siqueira Jordao Rodrigo.Siqueira at amd.com
Mon Mar 18 13:05:18 UTC 2024



On 3/18/24 6:50 AM, Srinivasan Shanmugam wrote:
> Adds descriptions for 'new_context', 'srf_updates', and 'surface_count',
> and removes the excess description for 'context'.
> 
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:4411: warning: Function parameter or member 'new_context' not described in 'commit_minimal_transition_state_in_dc_update'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:4411: warning: Function parameter or member 'srf_updates' not described in 'commit_minimal_transition_state_in_dc_update'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:4411: warning: Function parameter or member 'surface_count' not described in 'commit_minimal_transition_state_in_dc_update'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:4411: warning: Excess function parameter 'context' description in 'commit_minimal_transition_state_in_dc_update'
> 
> Cc: Wenjing Liu <wenjing.liu at amd.com>
> Cc: Alex Hung <alex.hung at amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Cc: Roman Li <roman.li at amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Cc: Tom Chung <chiahsuan.chung at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 119eee2c97d4..08ca97bb4160 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -4391,8 +4391,10 @@ static bool commit_minimal_transition_based_on_current_context(struct dc *dc,
>    * on current or new context
>    *
>    * @dc: DC structure, used to get the current state
> - * @context: New context
> + * @new_context: New context
>    * @stream: Stream getting the update for the flip
> + * @srf_updates: Surface updates
> + * @surface_count: Number of surfaces
>    *
>    * The function takes in current state and new state and determine a minimal
>    * transition state as the intermediate step which could make the transition

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>



More information about the amd-gfx mailing list