[PATCH] drm/amdgpu: Refine IB schedule error logging

Christian König christian.koenig at amd.com
Thu Mar 21 12:41:24 UTC 2024


Am 21.03.24 um 13:36 schrieb Lijo Lazar:
> Downgrade to debug information when IBs are skipped. Also, use dev_* to
> identify the device.
>
> Signed-off-by: Lijo Lazar <lijo.lazar at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> index 4b3000c21ef2..e4742b65032d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> @@ -304,12 +304,15 @@ static struct dma_fence *amdgpu_job_run(struct drm_sched_job *sched_job)
>   		dma_fence_set_error(finished, -ECANCELED);
>   
>   	if (finished->error < 0) {
> -		DRM_INFO("Skip scheduling IBs!\n");
> +		dev_dbg(adev->dev, "Skip scheduling IBs in ring(%s)",
> +			ring->name);
>   	} else {
>   		r = amdgpu_ib_schedule(ring, job->num_ibs, job->ibs, job,
>   				       &fence);
>   		if (r)
> -			DRM_ERROR("Error scheduling IBs (%d)\n", r);
> +			dev_err(adev->dev,
> +				"Error scheduling IBs (%d) in ring(%s)", r,
> +				ring->name);
>   	}
>   
>   	job->job_run_counter++;



More information about the amd-gfx mailing list