[patch] problems with "fix visible VRAM handling during faults"

Jeremy Day jsday at noreason.ca
Wed May 8 11:25:15 UTC 2024


Christian König <christian.koenig at amd.com> wrote:
> Am 08.05.24 um 12:17 schrieb Michel Dänzer:
> > Does this instead of your patch help by any chance?
> >
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> > index 109fe557a02b..29c197c00018 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> > @@ -427,7 +427,7 @@ bool amdgpu_res_cpu_visible(struct amdgpu_device *adev,
> >
> >          amdgpu_res_first(res, 0, res->size, &cursor);
> >          while (cursor.remaining) {
> > -               if ((cursor.start + cursor.size) >= adev->gmc.visible_vram_size)
> > +               if ((cursor.start + cursor.size) > adev->gmc.visible_vram_size)
> 
> Oh, good catch. Yes that might be it.

Yes, that does it.  Thanks!


More information about the amd-gfx mailing list