[PATCH 14/22] drm/amdgu: remove unused code

Huang, Tim Tim.Huang at amd.com
Fri May 10 06:43:42 UTC 2024


[AMD Official Use Only - General]

This patch is,

Reviewed-by: Tim Huang <Tim.Huang at amd.com>


> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Jesse
> Zhang
> Sent: Friday, May 10, 2024 10:51 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian
> <Christian.Koenig at amd.com>; Huang, Tim <Tim.Huang at amd.com>; Zhang,
> Jesse(Jie) <Jesse.Zhang at amd.com>; Zhang, Jesse(Jie)
> <Jesse.Zhang at amd.com>
> Subject: [PATCH 14/22] drm/amdgu: remove unused code
>
> The same code is executed when the condition err is true or false, because the
> code in the if-then branch and after the if statement is identical
>
> Signed-off-by: Jesse Zhang <Jesse.Zhang at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
> index 541dbd70d8c7..16d3deac375d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
> @@ -963,8 +963,6 @@ static int gfx_v7_0_init_microcode(struct
> amdgpu_device *adev)
>
>       snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_rlc.bin", chip_name);
>       err = amdgpu_ucode_request(adev, &adev->gfx.rlc_fw, fw_name);
> -     if (err)
> -             goto out;
>  out:
>       if (err) {
>               pr_err("gfx7: Failed to load firmware \"%s\"\n", fw_name);
> --
> 2.25.1



More information about the amd-gfx mailing list