[PATCH 06/22] drm/amd/pm: check the return of send smc msg for sienna_cichild

[Huang, Tim]

[AMD Official Use Only - General]

This patch is,

Reviewed-by: Tim Huang <Tim.Huang at amd.com>



> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Jesse
> Zhang
> Sent: Friday, May 10, 2024 10:50 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian
> <Christian.Koenig at amd.com>; Huang, Tim <Tim.Huang at amd.com>; Zhang,
> Jesse(Jie) <Jesse.Zhang at amd.com>; Zhang, Jesse(Jie)
> <Jesse.Zhang at amd.com>
> Subject: [PATCH 06/22] drm/amd/pm: check the return of send smc msg for
> sienna_cichild
>
> Set smu work laod mask may fail, so check return.
>
> Signed-off-by: Jesse Zhang <Jesse.Zhang at amd.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> index e426f457a017..e7ef8cb3a791 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> @@ -1782,8 +1782,10 @@ static int
> sienna_cichlid_set_power_profile_mode(struct smu_context *smu, long *
>                                                      smu->power_profile_mode);
>       if (workload_type < 0)
>               return -EINVAL;
> -     smu_cmn_send_smc_msg_with_param(smu,
> SMU_MSG_SetWorkloadMask,
> +     ret = smu_cmn_send_smc_msg_with_param(smu,
> SMU_MSG_SetWorkloadMask,
>                                   1 << workload_type, NULL);
> +     if (ret)
> +             dev_err(smu->adev->dev, "[%s] Failed to set work load mask!",
> __func__);
>
>       return ret;
>  }
> --
> 2.25.1