[PATCH v10 5/6] drm/amdgpu: Remove the MES self test

Christian König christian.koenig at amd.com
Mon May 13 15:53:01 UTC 2024


Am 10.05.24 um 10:50 schrieb Arunpravin Paneer Selvam:
> Remove MES self test as this conflicts the userqueue fence
> interrupts.

Please also completely remove the amdgpu_mes_self_test() function and 
any now unused code.

Regards,
Christian.

>
> Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |  3 ---
>   drivers/gpu/drm/amd/amdgpu/mes_v10_1.c     | 12 +-----------
>   drivers/gpu/drm/amd/amdgpu/mes_v11_0.c     | 14 +-------------
>   3 files changed, 2 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 7753a2e64d41..2d9fa3d0d4a4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -4719,9 +4719,6 @@ int amdgpu_device_resume(struct drm_device *dev, bool fbcon)
>   	}
>   	adev->in_suspend = false;
>   
> -	if (adev->enable_mes)
> -		amdgpu_mes_self_test(adev);
> -
>   	if (amdgpu_acpi_smart_shift_update(dev, AMDGPU_SS_DEV_D0))
>   		DRM_WARN("smart shift update failed\n");
>   
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c b/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c
> index 4d1121d1a1e7..b7bfb3185a30 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c
> @@ -1161,20 +1161,10 @@ static int mes_v10_0_early_init(void *handle)
>   	return 0;
>   }
>   
> -static int mes_v10_0_late_init(void *handle)
> -{
> -	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
> -
> -	if (!amdgpu_in_reset(adev))
> -		amdgpu_mes_self_test(adev);
> -
> -	return 0;
> -}
> -
>   static const struct amd_ip_funcs mes_v10_1_ip_funcs = {
>   	.name = "mes_v10_1",
>   	.early_init = mes_v10_0_early_init,
> -	.late_init = mes_v10_0_late_init,
> +	.late_init = NULL,
>   	.sw_init = mes_v10_1_sw_init,
>   	.sw_fini = mes_v10_1_sw_fini,
>   	.hw_init = mes_v10_1_hw_init,
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> index feb7fa2c304c..5923b7b0bd95 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> @@ -1274,22 +1274,10 @@ static int mes_v11_0_early_init(void *handle)
>   	return 0;
>   }
>   
> -static int mes_v11_0_late_init(void *handle)
> -{
> -	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
> -
> -	/* it's only intended for use in mes_self_test case, not for s0ix and reset */
> -	if (!amdgpu_in_reset(adev) && !adev->in_s0ix && !adev->in_suspend &&
> -	    (amdgpu_ip_version(adev, GC_HWIP, 0) != IP_VERSION(11, 0, 3)))
> -		amdgpu_mes_self_test(adev);
> -
> -	return 0;
> -}
> -
>   static const struct amd_ip_funcs mes_v11_0_ip_funcs = {
>   	.name = "mes_v11_0",
>   	.early_init = mes_v11_0_early_init,
> -	.late_init = mes_v11_0_late_init,
> +	.late_init = NULL,
>   	.sw_init = mes_v11_0_sw_init,
>   	.sw_fini = mes_v11_0_sw_fini,
>   	.hw_init = mes_v11_0_hw_init,



More information about the amd-gfx mailing list