[PATCH] drm/amd/display: Drop pixel_clock_mhz

Chung, ChiaHsuan (Tom) chiahsuan.chung at amd.com
Tue May 14 10:33:16 UTC 2024


This patch looks good to me.

Reviewed-by: Tom Chung <chiahsuan.chung at amd.com>

On 5/9/2024 9:55 AM, Mario Limonciello wrote:
> The pixel_clock_mhz property is populated in amdgpu_dm when Freesync is setup,
> but it is not used anywhere in amdgpu_dm. Remove the dead code.
>
> Cc:chiahsuan.chung at amd.com
> Signed-off-by: Mario Limonciello<mario.limonciello at amd.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 -
>   2 files changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index f80213b7e9f7..3054bf79fc99 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -11274,7 +11274,6 @@ void amdgpu_dm_update_freesync_caps(struct drm_connector *connector,
>   
>   		amdgpu_dm_connector->min_vfreq = 0;
>   		amdgpu_dm_connector->max_vfreq = 0;
> -		amdgpu_dm_connector->pixel_clock_mhz = 0;
>   		connector->display_info.monitor_range.min_vfreq = 0;
>   		connector->display_info.monitor_range.max_vfreq = 0;
>   		freesync_capable = false;
> @@ -11338,8 +11337,6 @@ void amdgpu_dm_update_freesync_caps(struct drm_connector *connector,
>   					connector->display_info.monitor_range.min_vfreq;
>   				amdgpu_dm_connector->max_vfreq =
>   					connector->display_info.monitor_range.max_vfreq;
> -				amdgpu_dm_connector->pixel_clock_mhz =
> -					range->pixel_clock_mhz * 10;
>   
>   				break;
>   			}
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> index 09519b7abf67..67647bb5999b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> @@ -678,7 +678,6 @@ struct amdgpu_dm_connector {
>   	 * value is set to zero when there is no FreeSync support.
>   	 */
>   	int max_vfreq ;
> -	int pixel_clock_mhz;
>   
>   	/* Audio instance - protected by audio_lock. */
>   	int audio_inst;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20240514/f0d4c829/attachment-0001.htm>


More information about the amd-gfx mailing list