[PATCH] drm/amdgpu: fix Kconfig for ISP

Alex Deucher alexander.deucher at amd.com
Tue May 14 20:47:14 UTC 2024


Add new config option and set proper dependencies for ISP.

Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
Cc: Pratap Nirujogi <pratap.nirujogi at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/Kconfig  |  1 +
 drivers/gpu/drm/amd/amdgpu/Makefile |  2 ++
 drivers/gpu/drm/amd/isp/Kconfig     | 17 +++++++++++++++++
 3 files changed, 20 insertions(+)
 create mode 100644 drivers/gpu/drm/amd/isp/Kconfig

diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig
index 22d88f8ef5279..aa037ac7ef24f 100644
--- a/drivers/gpu/drm/amd/amdgpu/Kconfig
+++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
@@ -83,3 +83,4 @@ config DRM_AMDGPU_WERROR
 source "drivers/gpu/drm/amd/acp/Kconfig"
 source "drivers/gpu/drm/amd/display/Kconfig"
 source "drivers/gpu/drm/amd/amdkfd/Kconfig"
+source "drivers/gpu/drm/amd/isp/Kconfig"
diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile b/drivers/gpu/drm/amd/amdgpu/Makefile
index 12ba76025cb7c..c95ec19a38264 100644
--- a/drivers/gpu/drm/amd/amdgpu/Makefile
+++ b/drivers/gpu/drm/amd/amdgpu/Makefile
@@ -325,6 +325,8 @@ amdgpu-y += $(AMD_DISPLAY_FILES)
 endif
 
 # add isp block
+ifneq ($(CONFIG_DRM_AMD_ISP),)
 amdgpu-y += amdgpu_isp.o
+endif
 
 obj-$(CONFIG_DRM_AMDGPU)+= amdgpu.o
diff --git a/drivers/gpu/drm/amd/isp/Kconfig b/drivers/gpu/drm/amd/isp/Kconfig
new file mode 100644
index 0000000000000..afa3579901009
--- /dev/null
+++ b/drivers/gpu/drm/amd/isp/Kconfig
@@ -0,0 +1,17 @@
+# SPDX-License-Identifier: MIT
+menu "ISP (Image Signal Processor) Configuration"
+	depends on DRM_AMDGPU
+
+config DRM_AMD_ISP
+	bool "Enable AMD Image Signal Processor IP support"
+	depends on DRM_AMDGPU
+	select MFD_CORE
+	select PM_GENERIC_DOMAINS if PM
+	help
+	Choose this option to enable ISP IP support for AMD SOCs.
+	This adds the ISP (Image Signal Processor) IP driver and wires
+	it up into the amdgpu driver.  The ACP block provides the DMA
+	engine for the V4L mipi driver. It is required for camera
+	on APUs which utilize a mipi camera.
+
+endmenu
-- 
2.45.0



More information about the amd-gfx mailing list