[PATCH] drm/amdgpu/display: Update kdoc for 'optc35_set_odm_combine'

Chung, ChiaHsuan (Tom) chiahsuan.chung at amd.com
Thu May 16 07:34:14 UTC 2024


Reviewed-by: Tom Chung <chiahsuan.chung at amd.com>

On 5/15/2024 11:23 PM, Srinivasan Shanmugam wrote:
> The parameters segment_width and last_segment_width are used to control
> the configuration of the Output Plane Processor (OPP), specifically the
> width of each segment that the display is divided into and the width of
> the last segment
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/../display/dc/optc/dcn35/dcn35_optc.c:59: warning: Function parameter or struct member 'segment_width' not described in 'optc35_set_odm_combine'
> drivers/gpu/drm/amd/amdgpu/../display/dc/optc/dcn35/dcn35_optc.c:59: warning: Function parameter or struct member 'last_segment_width' not described in 'optc35_set_odm_combine'
> drivers/gpu/drm/amd/amdgpu/../display/dc/optc/dcn35/dcn35_optc.c:59: warning: Excess function parameter 'timing' description in 'optc35_set_odm_combine'
>
> Cc: Tom Chung <chiahsuan.chung at amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Cc: Roman Li <roman.li at amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c
> index 7c9faa507ec2..dfa9364fe5a6 100644
> --- a/drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c
> @@ -50,7 +50,8 @@
>    * @optc: Output Pipe Timing Combine instance reference.
>    * @opp_id: Output Plane Processor instance ID.
>    * @opp_cnt: Output Plane Processor count.
> - * @timing: Timing parameters used to configure DCN blocks.
> + * @segment_width: Width of the segment.
> + * @last_segment_width: Width of the last segment.
>    *
>    * Return: void.
>    */


More information about the amd-gfx mailing list