[PATCH 0/2] Add support for Panel Power Savings property

Mario Limonciello mario.limonciello at amd.com
Tue May 21 16:21:08 UTC 2024


On 5/21/2024 11:14, Xaver Hugl wrote:
> Am Di., 21. Mai 2024 um 16:00 Uhr schrieb Mario Limonciello
> <mario.limonciello at amd.com>:
>>
>> On 5/21/2024 08:43, Simon Ser wrote:
>>> This makes sense to me in general. I like the fact that it's simple and
>>> vendor-neutral.
>>>
>>> Do we want to hardcode "panel" in the name? Are we sure that this will
>>> ever only apply to panels?
>>>
>>> Do we want to use a name which reflects the intent, rather than the
>>> mechanism? In other words, something like "color fidelity" = "preferred"
>>> maybe? (I don't know, just throwing ideas around.)
>>
>> In that vein, how about:
>>
>> "power saving policy"
>> --> "power saving"
>> --> "color fidelity"
> 
> It's not just about colors though, is it? The compositor might want to
> disable it to increase the backlight brightness in bright
> environments, so "color fidelity" doesn't really sound right

Either of these better?

"power saving policy"
--> "power saving"
--> "accuracy"

"power saving policy"
--> "allowed"
--> "forbidden"

Or any other idea?

> 
>>>
>>> Would be nice to add documentation for the property in the "standard
>>> connector properties" section.
>>
>> Ack.
>>



More information about the amd-gfx mailing list