[PATCH v1 04/10] drm/amdgpu: add prints while ip register dump

[Alex Deucher]

On Wed, May 22, 2024 at 3:30 AM Sunil Khatri <sunil.khatri at amd.com> wrote:
>
> add prints before and after ip registers are
> dump. It avoids user to think of system being
> stuck/hung as register dump takes time after a
> gpu hang.
>
> Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index e72e774d17e6..844dbb3d43c5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -5373,11 +5373,13 @@ int amdgpu_do_asic_reset(struct list_head *device_list_handle,
>         if (!test_bit(AMDGPU_SKIP_COREDUMP, &reset_context->flags)) {
>                 amdgpu_reset_reg_dumps(tmp_adev);
>
> +               dev_info(tmp_adev->dev, "Dumping IP Registers\n");

Maybe say "Dumping IP state" since this could also contain
non-register state in the future.

>                 /* Trigger ip dump before we reset the asic */
>                 for (i = 0; i < tmp_adev->num_ip_blocks; i++)
>                         if (tmp_adev->ip_blocks[i].version->funcs->dump_ip_state)
>                                 tmp_adev->ip_blocks[i].version->funcs
>                                 ->dump_ip_state((void *)tmp_adev);
> +               dev_info(tmp_adev->dev, "Dumping IP Registers Completed\n");

Same here.  WIth that fixed, this patch is:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

>         }
>
>         reset_context->reset_device_list = device_list_handle;
> --
> 2.34.1
>