[PATCH] drm/amd/amdgpu: Fix 'snprintf' output truncation warning

[Mario Limonciello]

On 5/28/2024 10:24, Pratap Nirujogi wrote:
> snprintf can truncate the output fw filename if the isp ucode_prefix
> exceeds 29 characters. Knowing ISP ucode_prefix is in the format
> isp_x_x_x, limiting the size of ucode_prefix[] to 10 characters
> to fix the warning.
> 
> Fixes the below warning:
> 
>     drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c: In function 'isp_early_init':
>     drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c:192:58: warning: 'snprintf'
>     output may be truncated before the last format character
>     [-Wformat-truncation=]
>       192 |         snprintf(fw_name, sizeof(fw_name), "amdgpu/%s.bin", ucode_prefix);
>           |                                                          ^
>     In function 'isp_load_fw_by_psp',
>         inlined from 'isp_early_init' at drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c:218:8:
>     drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c:192:9: note: 'snprintf' output between 12 and 41 bytes into a destination of size 40
>       192 |         snprintf(fw_name, sizeof(fw_name), "amdgpu/%s.bin", ucode_prefix);
>           |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Pratap Nirujogi <pratap.nirujogi at amd.com>

As the kernel robot reported this you should add a "Reported-by:" tag 
for it.

Otherwise LGTM (feel free to add that tag when committing).

Reviewed-by: Mario Limonciello <mario.limonciello at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
> index 240408486d6b..2a3f4668cb9b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
> @@ -96,7 +96,7 @@ static int isp_resume(void *handle)
>   static int isp_load_fw_by_psp(struct amdgpu_device *adev)
>   {
>   	const struct common_firmware_header *hdr;
> -	char ucode_prefix[30];
> +	char ucode_prefix[10];
>   	char fw_name[40];
>   	int r = 0;
>