[PATCH] drm/amdgpu/soc24: use common nbio callback to set remap offset

Wang, Yang(Kevin) KevinYang.Wang at amd.com
Wed May 29 18:19:28 UTC 2024


[AMD Official Use Only - AMD Internal Distribution Only]

Reviewed-by: Yang Wang <kevinyang.wang at amd.com>

Best Regards,
Kevin

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: Thursday, May 30, 2024 2:08 AM
To: Deucher, Alexander <Alexander.Deucher at amd.com>
Cc: amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu/soc24: use common nbio callback to set remap offset

Ping?

On Wed, May 8, 2024 at 3:42 PM Alex Deucher <alexander.deucher at amd.com> wrote:
>
> This fixes HDP flushes on systems with non-4K pages.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/soc24.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc24.c
> b/drivers/gpu/drm/amd/amdgpu/soc24.c
> index 12900488dd618..66c7138fc6aa4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/soc24.c
> +++ b/drivers/gpu/drm/amd/amdgpu/soc24.c
> @@ -372,11 +372,9 @@ static const struct amdgpu_asic_funcs
> soc24_asic_funcs = {
>
>  static int soc24_common_early_init(void *handle)  { -#define
> MMIO_REG_HOLE_OFFSET (0x80000 - PAGE_SIZE)
>         struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
> -       adev->rmmio_remap.reg_offset = MMIO_REG_HOLE_OFFSET;
> -       adev->rmmio_remap.bus_addr = adev->rmmio_base + MMIO_REG_HOLE_OFFSET;
> +       adev->nbio.funcs->set_reg_remap(adev);
>         adev->smc_rreg = NULL;
>         adev->smc_wreg = NULL;
>         adev->pcie_rreg = &amdgpu_device_indirect_rreg;
> --
> 2.45.0
>


More information about the amd-gfx mailing list