[PATCH] drm/amd/pm: add missing error handling in function smu_v13_0_6_allocate_dpm_context

[Zhou, Bob]

[AMD Official Use Only - AMD Internal Distribution Only]

Good catch! Thanks for your comments. I will fix this on next patch.

Regards,
Bob

-----Original Message-----
From: Wang, Yang(Kevin) <KevinYang.Wang at amd.com>
Sent: 2024年5月31日 15:43
To: Zhou, Bob <Bob.Zhou at amd.com>; amd-gfx at lists.freedesktop.org; Huang, Tim <Tim.Huang at amd.com>; Zhang, Jesse(Jie) <Jesse.Zhang at amd.com>
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Zhou, Bob <Bob.Zhou at amd.com>
Subject: RE: [PATCH] drm/amd/pm: add missing error handling in function smu_v13_0_6_allocate_dpm_context

[AMD Official Use Only - AMD Internal Distribution Only]

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Bob Zhou
Sent: Friday, May 31, 2024 3:36 PM
To: amd-gfx at lists.freedesktop.org; Huang, Tim <Tim.Huang at amd.com>; Zhang, Jesse(Jie) <Jesse.Zhang at amd.com>
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Zhou, Bob <Bob.Zhou at amd.com>
Subject: [PATCH] drm/amd/pm: add missing error handling in function smu_v13_0_6_allocate_dpm_context

Check return value to avoid null pointer dereference.

Signed-off-by: Bob Zhou <bob.zhou at amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index 15c0aa0ad443..419e46cfa065 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -451,6 +451,9 @@ static int smu_v13_0_6_allocate_dpm_context(struct smu_context *smu)

        smu_dpm->dpm_policies =
                kzalloc(sizeof(struct smu_dpm_policy_ctxt), GFP_KERNEL);
+       if (!smu_dpm->dpm_policies)
+               return -ENOMEM;

[Kevin]:

the 'smu_dpm->dpm_context' needs to be released together to avoid memory leak.

Best Regards,
Kevin
+
        if (!(smu->adev->flags & AMD_IS_APU)) {
                policy = &(smu_dpm->dpm_policies->policies[0]);

--
2.34.1