[PATCH 23/32] drm/amd/display: Add recovery timeout to FAMS2

Zaeem Mohamed zaeem.mohamed at amd.com
Fri May 31 16:51:36 UTC 2024


From: Dillon Varone <dillon.varone at amd.com>

[WHY&HOW]
Add 5ms timeout to trigger recovery and force allow P-State in DMUB.

Reviewed-by: Alvin Lee <alvin.lee2 at amd.com>
Acked-by: Zaeem Mohamed <zaeem.mohamed at amd.com>
Signed-off-by: Dillon Varone <dillon.varone at amd.com>
---
 drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c    | 1 +
 drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
index 0e70b95573ae..4e6f7bf8a5b4 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
+++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
@@ -1653,6 +1653,7 @@ void dc_dmub_srv_fams2_update_config(struct dc *dc,
 	/* send global configuration parameters */
 	global_cmd->config.global.max_allow_delay_us = 100 * 1000; //100ms
 	global_cmd->config.global.lock_wait_time_us = 5000; //5ms
+	global_cmd->config.global.recovery_timeout_us = 5000; //5ms
 
 	/* copy static feature configuration */
 	global_cmd->config.global.features.all = dc->debug.fams2_config.all;
diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
index d4d046ac82a4..53ea4a57bd44 100644
--- a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
+++ b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
@@ -1833,6 +1833,7 @@ struct dmub_cmd_fams2_global_config {
 	uint32_t lock_wait_time_us; // time to forecast acquisition of lock
 	uint32_t num_streams;
 	union dmub_fams2_global_feature_config features;
+	uint32_t recovery_timeout_us;
 	uint8_t pad[3];
 };
 
-- 
2.34.1



More information about the amd-gfx mailing list