[PATCH V2 0/4] Add panic support for all DCE/DCN

[Jocelyn Falempe]

On 31/10/2024 19:04, Alex Deucher wrote:
> This builds on the patches from Lu and Jocelyn to fill in
> panic support for all DCE/DCN variants and code pathes.
> 
> v2: refactor to provide cleaner history and share more
> code to provide a more consistent experience across
> DC and non-DC.

I wasn't able to build this patchset.

drivers/gpu/drm/amd/amdgpu/dce_v10_0.c:2712:31: error: 
‘amdgpu_display_get_scanout_buffer’ undeclared here (not in a function)
  2712 |         .get_scanout_buffer = amdgpu_display_get_scanout_buffer,
       |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   CC [M]  drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.o
make[6]: *** [scripts/Makefile.build:229: 
drivers/gpu/drm/amd/amdgpu/dce_v10_0.o] Error 1
make[6]: *** Waiting for unfinished jobs....
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c:2825:31: error: 
‘amdgpu_display_get_scanout_buffer’ undeclared here (not in a function)
  2825 |         .get_scanout_buffer = amdgpu_display_get_scanout_buffer,
       |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[6]: *** [scripts/Makefile.build:229: 
drivers/gpu/drm/amd/amdgpu/dce_v11_0.o] Error 1
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:1526:31: 
error: ‘amdgpu_display_get_scanout_buffer’ undeclared here (not in a 
function)
  1526 |         .get_scanout_buffer = amdgpu_display_get_scanout_buffer,


I think there is one patch missing, that should add the 
amdgpu_display_get_scanout_buffer() implementation.

I've built and tested the v1 which works on my 5700XT.

Thanks a lot for implementing drm_panic for all the other dcn/dce 
versions, I was hesitant to do that, because I can't test them.

Best regards,

-- 

Jocelyn



> 
> Alex Deucher (3):
>    drm/amd/display: add clear_tiling hubp callbacks
>    drm/amd/display: add clear_tiling mi callbacks
>    drm/amd/display: add non-DC drm_panic support
> 
> Jocelyn Falempe (1):
>    drm/amd/display: add DC drm_panic support
> 
>   drivers/gpu/drm/amd/amdgpu/dce_v10_0.c        |  27 +++++
>   drivers/gpu/drm/amd/amdgpu/dce_v11_0.c        |  27 +++++
>   drivers/gpu/drm/amd/amdgpu/dce_v6_0.c         |  27 +++++
>   drivers/gpu/drm/amd/amdgpu/dce_v8_0.c         |  26 +++++
>   .../amd/display/amdgpu_dm/amdgpu_dm_plane.c   | 103 +++++++++++++++++-
>   .../drm/amd/display/dc/dce/dce_mem_input.c    |  34 +++++-
>   .../amd/display/dc/hubp/dcn10/dcn10_hubp.c    |  15 +++
>   .../amd/display/dc/hubp/dcn10/dcn10_hubp.h    |   2 +
>   .../amd/display/dc/hubp/dcn20/dcn20_hubp.c    |  15 +++
>   .../amd/display/dc/hubp/dcn20/dcn20_hubp.h    |   2 +
>   .../amd/display/dc/hubp/dcn201/dcn201_hubp.c  |   1 +
>   .../amd/display/dc/hubp/dcn21/dcn21_hubp.c    |   1 +
>   .../amd/display/dc/hubp/dcn30/dcn30_hubp.c    |  17 +++
>   .../amd/display/dc/hubp/dcn30/dcn30_hubp.h    |   2 +
>   .../amd/display/dc/hubp/dcn31/dcn31_hubp.c    |   1 +
>   .../amd/display/dc/hubp/dcn32/dcn32_hubp.c    |   3 +-
>   .../amd/display/dc/hubp/dcn35/dcn35_hubp.c    |   1 +
>   .../amd/display/dc/hubp/dcn401/dcn401_hubp.c  |  15 ++-
>   .../amd/display/dc/hubp/dcn401/dcn401_hubp.h  |   2 +
>   drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h  |   1 +
>   .../gpu/drm/amd/display/dc/inc/hw/mem_input.h |   2 +
>   21 files changed, 316 insertions(+), 8 deletions(-)
>