[PATCH] drm/amdgpu: fix a mistake when removing mem_info_preempt_used sysfs

Huang, Tim Tim.Huang at amd.com
Mon Nov 11 09:41:03 UTC 2024


[Public]

This patch is,

Reviewed-by: Tim Huang <tim.huang at amd.com>



> -----Original Message-----
> From: Jesse.Zhang <Jesse.Zhang at amd.com>
> Sent: Monday, November 11, 2024 5:04 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian
> <Christian.Koenig at amd.com>; Prosyak, Vitaly <Vitaly.Prosyak at amd.com>;
> Huang, Tim <Tim.Huang at amd.com>; Zhang, Jesse(Jie)
> <Jesse.Zhang at amd.com>
> Subject: [PATCH] drm/amdgpu: fix a mistake when removing
> mem_info_preempt_used sysfs
>
> From: "Jesse.zhang at amd.com" <jesse.zhang at amd.com>
>
> Skip removing mem_info_preempt_used sysfs when unplugging the device.
>
> Signed-off-by: Jesse Zhang <jesse.zhang at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c
> index 33a714ddfbbc..9a0346ed6ea4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c
> @@ -138,7 +138,7 @@ void amdgpu_preempt_mgr_fini(struct
> amdgpu_device *adev)
>       if (ret)
>               return;
>
> -     if (!drm_dev_enter(adev_to_drm(adev), &idx)) {
> +     if (drm_dev_enter(adev_to_drm(adev), &idx)) {
>               device_remove_file(adev->dev,
> &dev_attr_mem_info_preempt_used);
>               drm_dev_exit(idx);
>       }
> --
> 2.25.1



More information about the amd-gfx mailing list