[PATCH v1 2/2] drm/amdgpu: add the argument description for gpu_addr

Paneer Selvam, Arunpravin arunpravin.paneerselvam at amd.com
Wed Nov 13 08:55:52 UTC 2024



On 11/13/2024 1:45 PM, Sunil Khatri wrote:
> Add argument description for the input argument
> gpu_addr for amdgpu_device_ip_set_powergating_state.
for amdgpu_seq64_alloc?
>
> Fixes the warning raised by the compiler:
> drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c:168:
> warning: Function parameter or struct member 'gpu_addr' not described in 'amdgpu_seq64_alloc
>
> Cc: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam at amd.com>
> Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> index 0defad71044c..d392cb0cbf61 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> @@ -157,6 +157,7 @@ void amdgpu_seq64_unmap(struct amdgpu_device *adev, struct amdgpu_fpriv *fpriv)
>    * @adev: amdgpu_device pointer
>    * @va: VA to access the seq in process address space
may be @gpu_addr description follows after the @va as per the input 
argument order in the function?

Regards,
Arun.
>    * @cpu_addr: CPU address to access the seq
> + * @gpu_addr: GPU address to access the seq
>    *
>    * Alloc a 64 bit memory from seq64 pool.
>    *



More information about the amd-gfx mailing list