[PATCH v1 1/2] drm/amdgpu: fix the variable name in comments

Khatri, Sunil sunil.khatri at amd.com
Fri Nov 22 07:59:41 UTC 2024


On 11/22/2024 1:20 PM, Christian König wrote:
> Am 21.11.24 um 18:37 schrieb Sunil Khatri:
>> Fix the variable name in comments to clean up the
>> warning in amdgpu_bo_create_isp_user.
>>
>> warning: Function parameter or struct member 'dbuf' not described in 
>> 'amdgpu_bo_create_isp_user'
>> warning: Excess function parameter 'dma_buf' description in 
>> 'amdgpu_bo_create_isp_user'
>
> Mhm, I think I would rather prefer changing the variable name.
>
> We used dma_buf basically everywhere else.

make Sense. i will update the variable name rather than the comment.

Thanks Sunil

>
> Christian.
>
>>
>> Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index 4e6d218839f9..89d84820e4b0 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -357,7 +357,7 @@ EXPORT_SYMBOL(amdgpu_bo_create_kernel);
>>    * amdgpu_bo_create_isp_user - create user BO for isp
>>    *
>>    * @adev: amdgpu device object
>> - * @dma_buf: DMABUF handle for isp buffer
>> + * @dbuf: DMABUF handle for isp buffer
>>    * @domain: where to place it
>>    * @bo:  used to initialize BOs in structures
>>    * @gpu_addr: GPU addr of the pinned BO
>


More information about the amd-gfx mailing list