[PATCH v2 1/2] drm/amdgpu: Update the variable name to dma_buf

Christian König christian.koenig at amd.com
Fri Nov 22 10:12:24 UTC 2024


Am 22.11.24 um 09:03 schrieb Sunil Khatri:
> Instead of fixing the warning for missing variable
> its better to update the variable name to match
> with the style followed in the code.
>
> This will fix the below mentioned warning:
> warning: Function parameter or struct member 'dbuf' not described in 'amdgpu_bo_create_isp_user'
> warning: Excess function parameter 'dma_buf' description in 'amdgpu_bo_create_isp_user'
>
> Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 4e6d218839f9..4f057996ef35 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -373,14 +373,14 @@ EXPORT_SYMBOL(amdgpu_bo_create_kernel);
>    * 0 on success, negative error code otherwise.
>    */
>   int amdgpu_bo_create_isp_user(struct amdgpu_device *adev,
> -			   struct dma_buf *dbuf, u32 domain, struct amdgpu_bo **bo,
> +			   struct dma_buf *dma_buf, u32 domain, struct amdgpu_bo **bo,
>   			   u64 *gpu_addr)
>   
>   {
>   	struct drm_gem_object *gem_obj;
>   	int r;
>   
> -	gem_obj = amdgpu_gem_prime_import(&adev->ddev, dbuf);
> +	gem_obj = amdgpu_gem_prime_import(&adev->ddev, dma_buf);
>   	*bo = gem_to_amdgpu_bo(gem_obj);
>   	if (!(*bo)) {
>   		dev_err(adev->dev, "failed to get valid isp user bo\n");



More information about the amd-gfx mailing list