[PATCH] drm/amdgpu: Remove gfxoff usage

[Zhang, Hawking]

[AMD Official Use Only - AMD Internal Distribution Only]

Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>

Regards,
Hawking
-----Original Message-----
From: Lazar, Lijo <Lijo.Lazar at amd.com>
Sent: Wednesday, November 27, 2024 14:14
To: amd-gfx at lists.freedesktop.org
Cc: Zhang, Hawking <Hawking.Zhang at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>; Khatri, Sunil <Sunil.Khatri at amd.com>
Subject: [PATCH] drm/amdgpu: Remove gfxoff usage

GFXOFF is not valid for these IP versions. Also, SDMA v4.4.2 is not in GFX domain.

Signed-off-by: Lijo Lazar <lijo.lazar at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c  | 4 ----  drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 2 --
 2 files changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
index f23df55d72fd..decb709707e2 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
@@ -4651,7 +4651,6 @@ static void gfx_v9_4_3_ip_dump(struct amdgpu_ip_block *ip_block)

        num_xcc = NUM_XCC(adev->gfx.xcc_mask);

-       amdgpu_gfx_off_ctrl(adev, false);
        for (xcc_id = 0; xcc_id < num_xcc; xcc_id++) {
                xcc_offset = xcc_id * reg_count;
                for (i = 0; i < reg_count; i++)
@@ -4659,7 +4658,6 @@ static void gfx_v9_4_3_ip_dump(struct amdgpu_ip_block *ip_block)
                                RREG32(SOC15_REG_ENTRY_OFFSET_INST(gc_reg_list_9_4_3[i],
                                                                   GET_INST(GC, xcc_id)));
        }
-       amdgpu_gfx_off_ctrl(adev, true);

        /* dump compute queue registers for all instances */
        if (!adev->gfx.ip_dump_compute_queues)
@@ -4668,7 +4666,6 @@ static void gfx_v9_4_3_ip_dump(struct amdgpu_ip_block *ip_block)
        num_inst = adev->gfx.mec.num_mec * adev->gfx.mec.num_pipe_per_mec *
                adev->gfx.mec.num_queue_per_pipe;
        reg_count = ARRAY_SIZE(gc_cp_reg_list_9_4_3);
-       amdgpu_gfx_off_ctrl(adev, false);
        mutex_lock(&adev->srbm_mutex);
        for (xcc_id = 0; xcc_id < num_xcc; xcc_id++) {
                xcc_offset = xcc_id * reg_count * num_inst; @@ -4695,7 +4692,6 @@ static void gfx_v9_4_3_ip_dump(struct amdgpu_ip_block *ip_block)
        }
        soc15_grbm_select(adev, 0, 0, 0, 0, 0);
        mutex_unlock(&adev->srbm_mutex);
-       amdgpu_gfx_off_ctrl(adev, true);
 }

 static void gfx_v9_4_3_ring_emit_cleaner_shader(struct amdgpu_ring *ring) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
index e70460693ef2..f206e98f2069 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
@@ -1948,7 +1948,6 @@ static void sdma_v4_4_2_dump_ip_state(struct amdgpu_ip_block *ip_block)
        if (!adev->sdma.ip_dump)
                return;

-       amdgpu_gfx_off_ctrl(adev, false);
        for (i = 0; i < adev->sdma.num_instances; i++) {
                instance_offset = i * reg_count;
                for (j = 0; j < reg_count; j++)
@@ -1956,7 +1955,6 @@ static void sdma_v4_4_2_dump_ip_state(struct amdgpu_ip_block *ip_block)
                                RREG32(sdma_v4_4_2_get_reg_offset(adev, i,
                                       sdma_reg_list_4_4_2[j].reg_offset));
        }
-       amdgpu_gfx_off_ctrl(adev, true);
 }

 const struct amd_ip_funcs sdma_v4_4_2_ip_funcs = {
--
2.25.1