[PATCH] drm/amdgpu/gfx9: Add Cleaner Shader Deinitialization in gfx_v9_0 Module

Christian König christian.koenig at amd.com
Tue Oct 1 07:21:34 UTC 2024


Am 01.10.24 um 09:00 schrieb Srinivasan Shanmugam:
> This commit addresses an omission in the previous patch related to the
> cleaner shader support for GFX9 hardware. Specifically, it adds the
> necessary deinitialization code for the cleaner shader in the
> gfx_v9_0_sw_fini function.
>
> The added line amdgpu_gfx_cleaner_shader_sw_fini(adev); ensures that any
> allocated resources for the cleaner shader are freed correctly, avoiding
> potential memory leaks and ensuring that the GPU state is clean for the
> next initialization sequence.
>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>

Acked-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index d7ef05cdb72e..1deb5eee794f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -2418,6 +2418,8 @@ static int gfx_v9_0_sw_fini(struct amdgpu_ip_block *ip_block)
>   	amdgpu_gfx_kiq_free_ring(&adev->gfx.kiq[0].ring);
>   	amdgpu_gfx_kiq_fini(adev, 0);
>   
> +	amdgpu_gfx_cleaner_shader_sw_fini(adev);
> +
>   	gfx_v9_0_mec_fini(adev);
>   	amdgpu_bo_free_kernel(&adev->gfx.rlc.clear_state_obj,
>   				&adev->gfx.rlc.clear_state_gpu_addr,



More information about the amd-gfx mailing list