[PATCH] drm/amdkfd: Move gfx12 trap handler to separate file
Jay Cornwall
jay.cornwall at amd.com
Fri Oct 4 18:52:55 UTC 2024
On 10/4/2024 04:42, Lancelot SIX wrote:
>> + * Copyright 2024 Advanced Micro Devices, Inc.
>
> I am not really sure bout the year policy in the kernel, but all the
> content here is dated from before 2024. The vast majority is taken form
> the cwsr_trap_handler_gfx10.asm file (copyright started in 2018), and
> even the gfx12 specific part have been introduced starting 2023.
I don't really know either. I looked at other files (e.g.
kfd_mqd_manager_v12.c) and we appear to reset the copyright date when
they're forked, but I'm not sure if that's an official policy.
>> + // If the PC points to S_ENDPGM then context save will fail if
>> STATUS.HALT is set.
>
> STATE_PRIV.HALT. Also, I am not sure this part is still required for
> gfx12. That being said, this has nothing to do with the rework, so
> removing is would be outside of the scope of this patch.
Yes, I'm avoiding any binary changes here to simplify things. There will
be some follow-up work which changes the binary. This patch is laying
the groundwork to avoid merge conflicts later.
Will fix up the other comments. Thanks.
More information about the amd-gfx
mailing list