[PATCH 2/2] drm/amdgpu: no need to log error in multi ring write

Christian König christian.koenig at amd.com
Mon Oct 7 13:46:40 UTC 2024


Am 03.10.24 um 10:13 schrieb Sunil Khatri:
> No need to log error in multi ring write as its taken
> care during ring commit.
>
> Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>
> Suggested-by: Christian König <christian.koenig at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
> index af8824e8da49..574336d6714a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
> @@ -388,9 +388,6 @@ static inline void amdgpu_ring_write_multiple(struct amdgpu_ring *ring,
>   	unsigned occupied, chunk1, chunk2;
>   	void *dst;
>   
> -	if (unlikely(ring->count_dw < count_dw))
> -		DRM_ERROR("amdgpu: writing more dwords to the ring than expected!\n");
> -
>   	occupied = ring->wptr & ring->buf_mask;
>   	dst = (void *)&ring->ring[occupied];
>   	chunk1 = ring->buf_mask + 1 - occupied;



More information about the amd-gfx mailing list