[PATCH v3 03/12] drm/fbdev-dma: Select FB_DEFERRED_IO

[Cavitt, Jonathan]

-----Original Message-----
From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of Thomas Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: simona at ffwll.ch; airlied at gmail.com; javierm at redhat.com; jfalempe at redhat.com
Cc: dri-devel at lists.freedesktop.org; amd-gfx at lists.freedesktop.org; intel-gfx at lists.freedesktop.org; intel-xe at lists.freedesktop.org; Thomas Zimmermann <tzimmermann at suse.de>; lkp <lkp at intel.com>; Maarten Lankhorst <maarten.lankhorst at linux.intel.com>; Maxime Ripard <mripard at kernel.org>; stable at vger.kernel.org
Subject: [PATCH v3 03/12] drm/fbdev-dma: Select FB_DEFERRED_IO
> 
> Commit 808a40b69468 ("drm/fbdev-dma: Implement damage handling and
> deferred I/O") added deferred I/O for fbdev-dma. Also select the
> Kconfig symbol FB_DEFERRED_IO (via FB_DMAMEM_HELPERS_DEFERRED). Fixes
> build errors about missing fbdefio, such as
> 
> drivers/gpu/drm/drm_fbdev_dma.c:218:26: error: 'struct drm_fb_helper' has no member named 'fbdefio'
>   218 |                 fb_helper->fbdefio.delay = HZ / 20;
>       |                          ^~
> drivers/gpu/drm/drm_fbdev_dma.c:219:26: error: 'struct drm_fb_helper' has no member named 'fbdefio'
>   219 |                 fb_helper->fbdefio.deferred_io = drm_fb_helper_deferred_io;
>       |                          ^~
> drivers/gpu/drm/drm_fbdev_dma.c:221:21: error: 'struct fb_info' has no member named 'fbdefio'
>   221 |                 info->fbdefio = &fb_helper->fbdefio;
>       |                     ^~
> drivers/gpu/drm/drm_fbdev_dma.c:221:43: error: 'struct drm_fb_helper' has no member named 'fbdefio'
>   221 |                 info->fbdefio = &fb_helper->fbdefio;
>       |                                           ^~
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Reported-by: kernel test robot <lkp at intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410050241.Mox9QRjP-lkp@intel.com/
> Fixes: 808a40b69468 ("drm/fbdev-dma: Implement damage handling and deferred I/O")
> Cc: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: Javier Martinez Canillas <javierm at redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Maxime Ripard <mripard at kernel.org>
> Cc: <stable at vger.kernel.org> # v6.11+

LGTM.

Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 1df4e627e3d3..db2e206a117c 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -338,7 +338,7 @@ config DRM_TTM_HELPER
>  config DRM_GEM_DMA_HELPER
>  	tristate
>  	depends on DRM
> -	select FB_DMAMEM_HELPERS if DRM_FBDEV_EMULATION
> +	select FB_DMAMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
>  	help
>  	  Choose this if you need the GEM DMA helper functions
>  
> -- 
> 2.46.0
> 
>