[PATCH 0/4] Ring padding CPU optimisation and some RFC bits

[Tvrtko Ursulin]

On 08/10/2024 19:10, Christian König wrote:
> Am 08.10.24 um 17:05 schrieb Tvrtko Ursulin:
>> From: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
>>
>> I've noticed the hardware ring padding optimisations have landed so I 
>> decided
>> to respin the CPU side optimisations.
>>
>> First two patches are simply adding ring fill helpers which deal with 
>> reducing
>> the CPU cost of emitting hundreds of nops from the 
>> for-amdgpu_ring_write loops.
>>
>> If receptive for the idea, please double-check I preserved endianess 
>> behaviour
>> as is.
> 
> I'm pretty sure that this was broken before or at least uses HW features 
> which are not guaranteed to work any more.
> 
> Sunil has already commited a set which does mostly the same as this 
> here. The only thing missing is the improvements for the IB patching and 
> a bunch of things I've been working on recently.
> 
> Going to send those out in a Minute, would be cool if you could run a 
> few performance analysis on those patches as well since you already seem 
> to have the setup for that.

Are you refering to "drop volatile" and "stop masking wptr" or something 
else? I haven't seen anything that adds an equivalent of my 
amgdpu_ring_fill yet.

Regards,

Tvrtko