[PATCH v6 02/12] drm/amdgpu: return error if phase2 suspend fails

Sunil Khatri sunil.khatri at amd.com
Fri Oct 18 13:23:17 UTC 2024


In function amdgpu_device_ip_suspend_phase2 if
suspend call fails for an IP then abort there
and return error to caller.

A failed functionality of IP is critical and
we should not proceed.

Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index b7277bef7463..3ccc5a608bf2 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3560,6 +3560,7 @@ static int amdgpu_device_ip_suspend_phase2(struct amdgpu_device *adev)
 		if (r) {
 			DRM_ERROR("suspend of IP block <%s> failed %d\n",
 				  adev->ip_blocks[i].version->funcs->name, r);
+			return r;
 		}
 		adev->ip_blocks[i].status.hw = false;
 		/* handle putting the SMC in the appropriate state */
-- 
2.34.1



More information about the amd-gfx mailing list