[PATCH v6 03/12] drm/amdgpu: return error on suspend failure

Sunil Khatri sunil.khatri at amd.com
Fri Oct 18 13:23:18 UTC 2024


In function amdgpu_reset_xgmi_reset_on_init_suspend
if suspend call fails for an IP then abort there
and return error to caller.

A failed functionality of IP is critical and
we should not proceed.

Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
index 3e2724590dbf..70f737c52a90 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
@@ -45,6 +45,7 @@ static int amdgpu_reset_xgmi_reset_on_init_suspend(struct amdgpu_device *adev)
 		if (r) {
 			dev_err(adev->dev, "suspend of IP block <%s> failed %d",
 				adev->ip_blocks[i].version->funcs->name, r);
+			return r;
 		}
 		adev->ip_blocks[i].status.hw = false;
 	}
-- 
2.34.1



More information about the amd-gfx mailing list