[PATCH] drm/amdkfd: remove extra use of volatile

[Alex Deucher]

On Tue, Oct 22, 2024 at 10:03 AM Victor Zhao <Victor.Zhao at amd.com> wrote:
>
> as the adding of mb() should be sufficient in function unmap_queues_cpsch,
> remove the add of volatile type as recommended
>
> Signed-off-by: Victor Zhao <Victor.Zhao at amd.com>

Acked-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 2 +-
>  drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 5a318376203c..38c19dc8311d 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -2048,7 +2048,7 @@ int amdkfd_fence_wait_timeout(struct device_queue_manager *dqm,
>  {
>         unsigned long end_jiffies = msecs_to_jiffies(timeout_ms) + jiffies;
>         struct device *dev = dqm->dev->adev->dev;
> -       volatile uint64_t *fence_addr = dqm->fence_addr;
> +       uint64_t *fence_addr = dqm->fence_addr;
>
>         while (*fence_addr != fence_value) {
>                 /* Fatal err detected, this response won't come */
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h
> index bddb169bb301..09ab36f8e8c6 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h
> @@ -260,7 +260,7 @@ struct device_queue_manager {
>         uint16_t                vmid_pasid[VMID_NUM];
>         uint64_t                pipelines_addr;
>         uint64_t                fence_gpu_addr;
> -       volatile uint64_t       *fence_addr;
> +       uint64_t                *fence_addr;
>         struct kfd_mem_obj      *fence_mem;
>         bool                    active_runlist;
>         int                     sched_policy;
> --
> 2.34.1
>