[PATCH] drm/amdgpu: Fix kdoc entry in 'amdgpu_vm_cpu_prepare'

Christian König christian.koenig at amd.com
Thu Sep 5 07:43:02 UTC 2024


Am 04.09.24 um 09:32 schrieb Srinivasan Shanmugam:
> This commit updates described non-existent parameters 'resv' and
> 'sync_mode', and failed to describe the existing 'sync' parameter.
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c:50: warning: Function parameter or struct member 'sync' not described in 'amdgpu_vm_cpu_prepare'
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c:50: warning: Excess function parameter 'resv' description in 'amdgpu_vm_cpu_prepare'
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c:50: warning: Excess function parameter 'sync_mode' description in 'amdgpu_vm_cpu_prepare'
>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c
> index 9ff59a4e6f15..29dbcdfeea8b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c
> @@ -39,8 +39,7 @@ static int amdgpu_vm_cpu_map_table(struct amdgpu_bo_vm *table)
>    * amdgpu_vm_cpu_prepare - prepare page table update with the CPU
>    *
>    * @p: see amdgpu_vm_update_params definition
> - * @resv: reservation object with embedded fence
> - * @sync_mode: synchronization mode
> + * @sync: synchronization mode

"@sync: sync obj with fences to wait on"

With that changed Reviewed-by: Christian König <christian.koenig at amd.com>


>    *
>    * Returns:
>    * Negativ errno, 0 for success.



More information about the amd-gfx mailing list