[PATCH] drm/amdgpu/mes12: switch SET_SHADER_DEBUGGER pkt to mes schq pipe

Alex Deucher alexdeucher at gmail.com
Wed Sep 11 13:46:26 UTC 2024


On Wed, Sep 11, 2024 at 4:48 AM Jack Xiao <Jack.Xiao at amd.com> wrote:
>
> The SET_SHADER_DEBUGGER packet must work with the added
> hardware queue, switch the packet submitting to mes schq pipe.
>
> Signed-off-by: Jack Xiao <Jack.Xiao at amd.com>

Acked-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c b/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c
> index e499b2857a01..ef05a4116230 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c
> @@ -479,6 +479,11 @@ static int mes_v12_0_misc_op(struct amdgpu_mes *mes,
>         union MESAPI__MISC misc_pkt;
>         int pipe;
>
> +       if (mes->adev->enable_uni_mes)
> +               pipe = AMDGPU_MES_KIQ_PIPE;
> +       else
> +               pipe = AMDGPU_MES_SCHED_PIPE;
> +
>         memset(&misc_pkt, 0, sizeof(misc_pkt));
>
>         misc_pkt.header.type = MES_API_TYPE_SCHEDULER;
> @@ -513,6 +518,7 @@ static int mes_v12_0_misc_op(struct amdgpu_mes *mes,
>                 misc_pkt.wait_reg_mem.reg_offset2 = input->wrm_reg.reg1;
>                 break;
>         case MES_MISC_OP_SET_SHADER_DEBUGGER:
> +               pipe = AMDGPU_MES_SCHED_PIPE;
>                 misc_pkt.opcode = MESAPI_MISC__SET_SHADER_DEBUGGER;
>                 misc_pkt.set_shader_debugger.process_context_addr =
>                                 input->set_shader_debugger.process_context_addr;
> @@ -530,11 +536,6 @@ static int mes_v12_0_misc_op(struct amdgpu_mes *mes,
>                 return -EINVAL;
>         }
>
> -       if (mes->adev->enable_uni_mes)
> -               pipe = AMDGPU_MES_KIQ_PIPE;
> -       else
> -               pipe = AMDGPU_MES_SCHED_PIPE;
> -
>         return mes_v12_0_submit_pkt_and_poll_completion(mes, pipe,
>                         &misc_pkt, sizeof(misc_pkt),
>                         offsetof(union MESAPI__MISC, api_status));
> --
> 2.41.0
>


More information about the amd-gfx mailing list