[PATCH] drm/amdgpu: fix warning of drm_mm_clean

[Alex Deucher]

On Tue, Apr 8, 2025 at 5:53 AM Christian König <christian.koenig at amd.com> wrote:
>
> Am 08.04.25 um 10:23 schrieb ZhenGuo Yin:
> > Kernel doorbell BOs needs to be freed before ttm_fini.
> >
> > Fixes: 54c30d2a8def ("drm/amdgpu: create kernel doorbell pages")
> > Signed-off-by: ZhenGuo Yin <zhenguo.yin at amd.com>
>
> At least from my point that patch seems to make a lot of sense, so feel free to add Reviewed-by: Christian König <christian.koenig at amd.com>.
>
> But I would at least give Alex a chance to take a loop and double check.

Looks correct.

Acked-by: Alex Deucher <alexander.deucher at amd.com>

>
> Regards,
> Christian.
>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > index d4b01ef00025..ff48096c1d80 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > @@ -3508,6 +3508,7 @@ static int amdgpu_device_ip_fini(struct amdgpu_device *adev)
> >                       amdgpu_device_mem_scratch_fini(adev);
> >                       amdgpu_ib_pool_fini(adev);
> >                       amdgpu_seq64_fini(adev);
> > +                     amdgpu_doorbell_fini(adev);
> >               }
> >               if (adev->ip_blocks[i].version->funcs->sw_fini) {
> >                       r = adev->ip_blocks[i].version->funcs->sw_fini(&adev->ip_blocks[i]);
> > @@ -4851,7 +4852,6 @@ void amdgpu_device_fini_sw(struct amdgpu_device *adev)
> >
> >               iounmap(adev->rmmio);
> >               adev->rmmio = NULL;
> > -             amdgpu_doorbell_fini(adev);
> >               drm_dev_exit(idx);
> >       }
> >
>