[v2 1/2] drm/amdgpu: Enable per-queue reset for SDMA v4.4.2 on IP v9.5.0

[Huang, Tim]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Jesse,

> -----Original Message-----
> From: Jesse.zhang at amd.com <jesse.zhang at amd.com>
> Sent: Tuesday, April 8, 2025 2:33 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian
> <Christian.Koenig at amd.com>; Huang, Tim <Tim.Huang at amd.com>; Lazar,
> Lijo <Lijo.Lazar at amd.com>; Zhang, Jesse(Jie) <Jesse.Zhang at amd.com>; Zhang,
> Jesse(Jie) <Jesse.Zhang at amd.com>
> Subject: [v2 1/2] drm/amdgpu: Enable per-queue reset for SDMA v4.4.2 on IP
> v9.5.0
>
> Add support for per-queue reset on SDMA v4.4.2 when running with:
> 1. MEC firmware version 17 or later

Please ensure this firmware version is aligned with code 0xf. With this addressed,

This patch is,

Reviewed-by: Tim Huang <tim.huang at amd.com>



> 2. DPM indicates SDMA reset is supported
>
> v2: Fixed supported firmware versions  (Lijo)
>
> Signed-off-by: Jesse.Zhang <Jesse.zhang at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
> b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
> index 688a720bbbbd..673ecd208c6d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
> @@ -2373,7 +2373,9 @@ static void
> sdma_v4_4_2_update_reset_mask(struct amdgpu_device *adev)
>                       adev->sdma.supported_reset |=
> AMDGPU_RESET_TYPE_PER_QUEUE;
>               break;
>       case IP_VERSION(9, 5, 0):
> -             /*TODO: enable the queue reset flag until fw supported */
> +             if ((adev->gfx.mec_fw_version >= 0xf) &&
> amdgpu_dpm_reset_sdma_is_supported(adev))
> +                     adev->sdma.supported_reset |=
> AMDGPU_RESET_TYPE_PER_QUEUE;
> +             break;
>       default:
>               break;
>       }
> --
> 2.25.1