[PATCH 7/9] drm/amdgpu: don't swallow errors in amdgpu_userqueue_resume_all()

Khatri, Sunil sukhatri at amd.com
Fri Apr 11 16:07:25 UTC 2025


Reviewed-by: Sunil Khatri <sunil.khatri at amd.com>

On 4/11/2025 7:42 PM, Alex Deucher wrote:
> since we loop through the queues |= the errors.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c
> index f5c2489baae43..aa7222137c31d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c
> @@ -423,7 +423,7 @@ amdgpu_userqueue_resume_all(struct amdgpu_userq_mgr *uq_mgr)
>   	/* Resume all the queues for this process */
>   	idr_for_each_entry(&uq_mgr->userq_idr, queue, queue_id) {
>   		userq_funcs = adev->userq_funcs[queue->queue_type];
> -		ret = userq_funcs->map(uq_mgr, queue);
> +		ret |= userq_funcs->map(uq_mgr, queue);
>   	}
>   
>   	if (ret)


More information about the amd-gfx mailing list